Repository navigation
Fix Braintrust redaction false positives - #2
Merged
Merged
Conversation
Contributor
Author
|
Validated in CI: run 38440542932 published 129 rows to Braintrust with nothing withheld. In the next run, 4 values were withheld and the experiment still published. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The first full ClawBench run graded all 129 trials but published nothing to Braintrust: the publisher's safety check rejected the payload. The redactor had three false positives, all from code inherited from
kernel-mcp-server:"Email address:"followed by a new line was read as anaddressfield whose value was the next lines.const cookie=page.getByRole(...)was read as acookie=credential.'Work email':'[REDACTED]', the checker took the label's closing quote for an opening one, then skipped[REDACTED]as if it were a snapshot attribute.In each case the redactor and the safety check disagreed, and one disagreement aborted the whole experiment.
Changes:
[WITHHELD]and logs a count. An unexpected value costs that value, not the experiment. The safety check still runs on the final payload.Validation
bun testpasses (21 tests, including regressions for each case and for withholding), along withtscand prettier.